Register repo when cloning and remove mount and unmount#203
Merged
Conversation
Register the repo when cloning rather than when mounting
wilbaker
force-pushed
the
regsiter_when_cloning
branch
2 times, most recently
from
e476e07 to
adf535d
Compare
wilbaker
changed the title
wilbaker
force-pushed
the
regsiter_when_cloning
branch
from
adf535d to
b14b20b
Compare
wilbaker
force-pushed
the
regsiter_when_cloning
branch
from
b14b20b to
681288f
Compare
derrickstolee
approved these changes
Oct 30, 2019
Contributor
There was a problem hiding this comment.
Assuming the current build succeeds, I think we should merge as-is. The other TODOs can be their own PRs to keep the size small.
In particular, deleting the mount process code should be easy to demonstrate no change in behavior.
Thoughts?
Edit: italicized above
kewillford
reviewed
Oct 30, 2019
Member
Author
I can go aheads and do that. This will introduce a bit of a regression because right now repos are never being unregistered, however, my next PR can add the auto-unregister behavior we need to the service. |
- Remove mount and unmount verbs - Clone no longer calls mount - Removed mount-all and unmount-all from the service verb - Updated functional tests as needed for above changes - Remove code for unloading the kext from the installer, there is no kext for Scalar - Stop calling 'service --unmount-all' as '--unmount-all' is no longer supported. For now call '--help' instead (until the service is able to stop its inflight maintenance task).
wilbaker
force-pushed
the
regsiter_when_cloning
branch
from
681288f to
e0c16fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #15
Resolves #118
Part of the work required for #111
serviceverb (removemount-allandunmount-all, renamelist-mounted)Follow up work
clone(and other verbs where appropriate) to write to the registry directly rather than communicating with the service over a pipe (part of the remaining work for [Mount Removal] Move repo registration from mount verb to clone verb #111)